Missing push notifications for all but first device when sending through Delayed::Job #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure why this is, or why my fix fixes this problem (or even whether anyone else has encountered this), but I've noticed that when I have multiple devices queued up for push notifications in a Delayed::Job, the PRX Master branch doesn't seem to successfully send notifications to any device beyond the first one. At least that was my experience on Heroku.
I was able to solve this problem by adding a sleep() instruction for a VERY small fraction of time (specifically 0.00000001). If no one else has experienced this problem, I'd recommend rejecting my pull request. Also, if there's some better solution to this, I'd appreciate knowing about it. If, however, there are others who have experienced this issue, and no solution has been found, I recommend this, as it is simple, and does not seem to have singificant drawbacks.