Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Realtime #261

Merged
merged 5 commits into from
Dec 11, 2023
Merged

Realtime #261

merged 5 commits into from
Dec 11, 2023

Conversation

lishaduck
Copy link
Member

@lishaduck lishaduck commented Dec 9, 2023

Description

This PR switches the code to use realtime updates instead of re-fetching the state a trillion(-ish) times.

Closes: #134

Type of Change

@lishaduck lishaduck added enhancement New feature or request help-wanted Extra attention is needed dart Regards Dart code labels Dec 9, 2023
@lishaduck lishaduck added this to the ELO Work milestone Dec 9, 2023
@lishaduck lishaduck self-assigned this Dec 9, 2023
@lishaduck lishaduck marked this pull request as ready for review December 9, 2023 18:50
@lishaduck lishaduck requested a review from a team as a code owner December 9, 2023 18:51
@lishaduck
Copy link
Member Author

This is done, @PetalCat, @ParkerH27! It'll fail CI until #253 is finished, but this is important enough to ignore the failures.

@lishaduck
Copy link
Member Author

Oh, we'll need to fix the flutter version in CI to be unlocked again. Maybe use ~ this time?

@lishaduck
Copy link
Member Author

Oh, we'll need to fix the flutter version in CI to be unlocked again. Maybe use ~ this time?

And it's broken on main too... yeah, that'll need fixing.

Streams let us fetch the coins in realtime.
Use correct media query.
Maintain the correct size when viewing loading coins.
Fix logic for nullified button.
Once #261 merges, this can be removed.
@lishaduck lishaduck added this pull request to the merge queue Dec 11, 2023
Merged via the queue into main with commit 396bfb5 Dec 11, 2023
9 checks passed
@lishaduck lishaduck deleted the realtime branch December 13, 2023 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dart Regards Dart code enhancement New feature or request help-wanted Extra attention is needed
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Realtime API
2 participants