Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init PetalNotes #147

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Init PetalNotes #147

wants to merge 5 commits into from

Conversation

lishaduck
Copy link
Member

@lishaduck lishaduck commented Jan 19, 2025

Sorta WIP


Resolves #149.

@lishaduck lishaduck added enhancement New feature or request javascript Pull requests that update Javascript code labels Jan 19, 2025
@lishaduck lishaduck self-assigned this Jan 19, 2025
@lishaduck lishaduck requested a review from ParkerH27 as a code owner January 19, 2025 03:02
Copy link

socket-security bot commented Jan 19, 2025

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@chromatic-com/[email protected] Transitive: filesystem +2 638 kB ghengeveld
npm/@storybook/[email protected] None +3 3.03 MB domyen, ghengeveld, jreinhold, ...9 more
npm/@storybook/[email protected] Transitive: environment +9 3.58 MB yannbf
npm/@storybook/[email protected] Transitive: environment +20 4.84 MB domyen, ghengeveld, jreinhold, ...9 more
npm/@storybook/[email protected] None +8 3.51 MB storybook-bot
npm/@storybook/[email protected] None +2 1.87 MB domyen, ghengeveld, jreinhold, ...9 more
npm/@storybook/[email protected] Transitive: environment +7 2.58 MB storybook-bot
npm/@storybook/[email protected] None +5 105 kB storybook-bot
npm/@storybook/[email protected] None +10 1.19 MB storybook-bot
npm/@storybook/[email protected] environment, eval +38 9.65 MB storybook-bot
npm/@sveltejs/[email protected] environment 0 8.59 kB svelte-admin
npm/@sveltejs/[email protected] None +9 1.56 MB conduitry, dominik_g, rich_harris, ...1 more
npm/@sveltejs/[email protected] Transitive: environment +7 834 kB conduitry, dominik_g, rich_harris, ...1 more
npm/@tailwindcss/[email protected] None +1 65 kB adamwathan
npm/@tailwindcss/[email protected] None +3 175 kB adamwathan
npm/@tailwindcss/[email protected] Transitive: environment, filesystem, shell, unsafe +4 310 kB adamwathan
npm/@types/[email protected] None +2 219 kB types
npm/@vitest/[email protected] environment Transitive: filesystem, shell +48 17.1 MB vitestbot
npm/@vitest/[email protected] Transitive: environment, filesystem +21 6.79 MB antfu, oreanno, patak, ...1 more
npm/[email protected] None 0 5.55 MB chromatic-ci-bot
npm/[email protected] None 0 2.96 MB marijn
npm/[email protected] filesystem, unsafe +6 1.39 MB ota-meshi
npm/[email protected] None 0 560 kB laobubu
npm/[email protected] 🔁 npm/[email protected] Transitive: filesystem, shell, unsafe +30 5.22 MB webpro

🚮 Removed packages: npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

@lishaduck lishaduck force-pushed the svelte branch 3 times, most recently from 7dbf37f to 5191ab1 Compare January 20, 2025 04:32
Copy link

socket-security bot commented Jan 20, 2025

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@lishaduck
Copy link
Member Author

@PetalCat, can you review? Specifically 60dff66, which is where the magic is.

Copy link
Collaborator

@PetalCat PetalCat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty snazzy and mostly makes sense

And off of the play CDN.

Unfortunately, Fontaine has issues with Tailwind’s generated styles, see unjs/fontaine#446.

Also, `@tailwindcss/forms` is really ugly with our styles.

Fixes: #5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Init PetalNotes
2 participants