Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incorrect use of GrowFactors() in Policy and Parameters classes #2852

Merged
merged 12 commits into from
Dec 16, 2024

Conversation

martinholmer
Copy link
Collaborator

@martinholmer martinholmer commented Dec 15, 2024

Fixes #2851 by removing two self._gfactors = GrowFactors() statements and making associated code changes.

Also, simplifies Policy.set_rates logic by eliminating code that has been obsolete since April 2024 when PR #2732 was merged.

Copy link

codecov bot commented Dec 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.42%. Comparing base (0411f9c) to head (f71b8b1).
Report is 13 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2852      +/-   ##
==========================================
- Coverage   99.42%   99.42%   -0.01%     
==========================================
  Files          13       13              
  Lines        2619     2618       -1     
==========================================
- Hits         2604     2603       -1     
  Misses         15       15              
Flag Coverage Δ
unittests 99.42% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
taxcalc/__init__.py 100.00% <100.00%> (ø)
taxcalc/calculator.py 100.00% <100.00%> (ø)
taxcalc/parameters.py 100.00% <100.00%> (ø)
taxcalc/policy.py 100.00% <100.00%> (ø)
taxcalc/taxcalcio.py 100.00% <100.00%> (ø)

@jdebacker jdebacker merged commit df06211 into PSLmodels:master Dec 16, 2024
9 checks passed
@martinholmer martinholmer deleted the fix-growfactors-use branch December 16, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect projection of indexed policy parameters in some cases
2 participants