Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] Use raw url for image assets #26

Merged
merged 89 commits into from
Jul 26, 2024
Merged

Conversation

youwuyou
Copy link
Collaborator

In #24 we used the relative path to images used in the documentation, but as described in Documenter.jl open issue here this differs from the path that is deployed. Thus we use raw url to images instead.

youwuyou and others added 30 commits June 6, 2024 18:39
…e consideration by alterning workgroup size etc
remove spacing for `V`

Co-authored-by: Ludovic Räss <[email protected]>
remove spacing for `∇V`

Co-authored-by: Ludovic Räss <[email protected]>
@youwuyou youwuyou added the documentation Improvements or additions to documentation label Jul 25, 2024
@youwuyou youwuyou requested a review from utkinis July 25, 2024 12:58
@youwuyou youwuyou requested a review from luraess July 25, 2024 13:04
@luraess
Copy link
Member

luraess commented Jul 25, 2024

Else it looks good to me

@luraess
Copy link
Member

luraess commented Jul 26, 2024

@utkinis upon your final check it could be ready to merge

@utkinis utkinis merged commit 0bc227b into main Jul 26, 2024
2 checks passed
@utkinis utkinis deleted the yw/test-documentation branch July 26, 2024 11:30
@utkinis
Copy link
Member

utkinis commented Jul 26, 2024

Thanks for the updates, merged. The PR looked a bit weird in a sense that it included 89 commits. I suspect that maybe it's because @youwuyou re-used the deleted branch yw/test-documentation, but I couldn't find any infos on that online. I don't think there is a problem as only the files that actually changed were in the PR =)

@luraess
Copy link
Member

luraess commented Jul 26, 2024

Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants