Style changes and typing, typing everywhere #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* reorganized imports - automatically changed order of imports in some files and removed unused, * added explicit typing to all fields and methods in RedGymEnv (and all files that use this class) * as almost all methods and fields in RedGymEnv are private, they were renamed to start with _underscore Warning: not tested against older versions of python 3
Also added some missed type hints
|
Having typing would allow using |
|
Hi! Looks nice! How thoroughly have you tested all of these changes? Also was the change of default environments from 16 to 4 intentional? |
|
Testing was not too thorough - I successfully started learning on the "_fast" script as well as the old one. The interactive mode script also works. As for 16 -> 4 change - no, I changed it so that it runs on my old PC well, and left it in by accident. Fixing that ASAP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning: not tested against older versions of python 3