Add module to extract message values for use in scripting #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkueng
reviewed
Nov 6, 2024
There was a problem hiding this comment.
Generally looks good.
Can you add some unit test under https://github.com/PX4/pyulog/tree/main/test?
And can you check the relevant CI failures? https://github.com/PX4/pyulog/actions/runs/11639019887/job/32414624361?pr=106
pyulog/extract_message.py:8:0: C0301: Line too long (112/100) (line-too-long)
pyulog/extract_message.py:21:11: C0123: Use isinstance() rather than type() for a typecheck. (unidiomatic-typecheck)
pyulog/extract_message.py:49:12: C0200: Consider using enumerate instead of iterating with range and len (consider-using-enumerate)
…t_dataset(message), resolve CI failures (shorter lines, better type check, enumerate vs iterate), add basic unit test
|
Okay thanks for your input. I was able to implement the changes you suggested (ulog.data_list -> ulog.get_dataset(message), removing the messages.split) and resolve all the CI failures (related to this extract_message module). I did create a very basic unit test by modifying the ulog2csv test, but it is my first unit test so let me know if it needs some more work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit creates a module
extract_messagefor extracting contents from a ULog message into a list to be used for scripting with ULog files. The module contains one function that takes in a ULog file, the desired message, and optionally a start and end time and returns a list of records from the ULog message as key-value pairs. I created this code by modifying the ulog2csv module.