Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependency name for scikit-learn in setup.py #283

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

linkedlist771
Copy link

Description:

This pull request fixes an issue in setup.py where the scikit-learn dependency was incorrectly listed as "sklearn" instead of the correct name "scikit-learn". This change ensures that the correct package is installed when setting up the project.

Changes Made:

  • Modified line 119 in setup.py:
    • Replaced "sklearn" with "scikit-learn" in the requires list.

Reason for Change:

The current dependency name "sklearn" is incorrect and will lead to failure when installing project dependencies. The correct package name for scikit-learn is "scikit-learn". "sklearn" has been deprecated, if we use this name, a runtime Error will raise(My env, ubuntu 20.04). This change ensures that the setup process installs the correct package.

Test Coverage:

This change does not affect the project's functionality and does not require additional testing.

Additional Notes:

None.

@CLAassistant
Copy link

CLAassistant commented May 23, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@linkedlist771
Copy link
Author

@xiaoyao4573 Can you review it?

@Rex-HH
Copy link

Rex-HH commented Sep 30, 2024

不太懂这个,现在这PaddleHelix 安装不了,有什么办法安装这个修改过的版本吗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants