Fix eval hang #9053
Closed
Fix eval hang #9053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #9053 +/- ##
========================================
Coverage 52.95% 52.96%
========================================
Files 656 656
Lines 106286 106286
========================================
+ Hits 56289 56293 +4
+ Misses 49997 49993 -4 ☔ View full report in Codecov by Sentry. |
ZHUI
reviewed
Sep 13, 2024
| @@ -1532,7 +1532,7 @@ def get_eval_dataloader(self, eval_dataset: Optional[Dataset] = None) -> DataLoa | |||
| eval_dataset, | |||
| batch_sampler=eval_sampler, | |||
| collate_fn=self.data_collator, | |||
| num_workers=self.args.dataloader_num_workers, | |||
| num_workers=0, | |||
There was a problem hiding this comment.
需要合入吗？这个建议查根本原因吧。num_worker=0略微影响性能。
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
APIs
Description