[Unified Checkpoint] Support expert parallel #9055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9055 +/- ##
===========================================
- Coverage 53.29% 53.24% -0.06%
===========================================
Files 652 652
Lines 105483 105599 +116
===========================================
+ Hits 56222 56225 +3
- Misses 49261 49374 +113 ☔ View full report in Codecov by Sentry. |
DesmonDay
force-pushed
the
support_ep
branch
from
f5b02c3
to
cc5463c
Compare
…nto support_ep
|
ready for review？ |
yes, come!!! |
ZHUI
reviewed
Sep 23, 2024
| try: | ||
| from paddle.base import core | ||
| except: | ||
| core = None |
| expected_keys = set() | ||
| for key in model_state_dict.keys(): | ||
| if getattr(model_state_dict[key], "no_sync", False): | ||
| expected_keys.add(key) |
There was a problem hiding this comment.
非no_sync的QKV参数，是通过额外的广播加载? 模型，opt，master weight各是怎样?
| @@ -1982,16 +2083,58 @@ def gather_sharded_object(index_file, total_size, is_optimizer=False): | |||
| return index_file_list, total_size_list | |||
|
|
|||
|
|
|||
| def rename_shard_file(args, shard_file, file_name): | |||
| """rename shard file when using expert_parallel.""" | |||
There was a problem hiding this comment.
注释，解释一下？这里是还是按照原来的方式命名，修改一下? 为什么不是moe从新写一个？
| def generate_base_static_name(vname): | ||
| # return base static name and specific type name, like [embedding_0.w_0, moment1_0] | ||
| if FP32_MASTER in vname: | ||
| vname = vname.split("_" + FP32_MASTER + "_") | ||
| return vname[0], vname[1] | ||
| else: | ||
| vname = vname.split(".") |
DesmonDay
added a commit
to DesmonDay/PaddleNLP
that referenced
this pull request
Oct 16, 2024
DesmonDay
added a commit
that referenced
this pull request
Oct 16, 2024
* [Unified Checkpoint] Support expert parallel (#9055) * update code * [Unified Checkpoint] Fix generation config save (#9223) * [Unified Checkpoint] update async_save_info in develop (#9173) * [Unified Checkpoint] update async save logic (#9274) * update async save signal * fix async save hang * bug fix --------- Co-authored-by: Weiguo Zhu <[email protected]>
DrownFish19
pushed a commit
to DrownFish19/PaddleNLP
that referenced
this pull request
Oct 16, 2024
wawltor
pushed a commit
that referenced
this pull request
Oct 17, 2024
* [Unified Checkpoint] Support expert parallel (#9055) * update code * [Unified Checkpoint] Fix generation config save (#9223) * [Unified Checkpoint] update async_save_info in develop (#9173) * [Unified Checkpoint] update async save logic (#9274) * update async save signal * fix async save hang * bug fix * bug fix * [Trainer] fix save_model (#9286) * bug fix * bug fix --------- Co-authored-by: Weiguo Zhu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Description
Support expert parallel for unified checkpoint.