Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove refined recompute deep copy #9617
base: develop
Are you sure you want to change the base?
remove refined recompute deep copy #9617
Changes from 16 commits
b6429c0
6b93359
64084ca
258b48b
79b86f6
927d157
2878179
39bd2c8
92d7e82
aa91e8e
2486c2a
688eb18
1b14cba
c81a8b3
0035f4f
69a5123
b1f0ef8
a8f6ac8
150c4dc
00b5e2c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/PaddlePaddle/PaddleNLP/blob/1842d6d133525a2ba72d1e26aecbbca54b78f8f9/llm/run_finetune.py#L156C1-L160C6
这部分看可以加到trainer 或者哪里吗?否则很容易漏写
Check warning on line 1784 in paddlenlp/trainer/training_args.py
Codecov / codecov/patch
paddlenlp/trainer/training_args.py#L1784
Check warning on line 1800 in paddlenlp/trainer/training_args.py
Codecov / codecov/patch
paddlenlp/trainer/training_args.py#L1791-L1800
Check warning on line 1804 in paddlenlp/trainer/training_args.py
Codecov / codecov/patch
paddlenlp/trainer/training_args.py#L1804
Check warning on line 1808 in paddlenlp/trainer/training_args.py
Codecov / codecov/patch
paddlenlp/trainer/training_args.py#L1808
Check warning on line 1815 in paddlenlp/trainer/training_args.py
Codecov / codecov/patch
paddlenlp/trainer/training_args.py#L1810-L1815
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
skip_recompute_ops 这个没有了,现在加在哪里?
Check warning on line 622 in paddlenlp/transformers/llama/modeling.py
Codecov / codecov/patch
paddlenlp/transformers/llama/modeling.py#L622
Check warning on line 624 in paddlenlp/transformers/llama/modeling.py
Codecov / codecov/patch
paddlenlp/transformers/llama/modeling.py#L624
Check warning on line 632 in paddlenlp/transformers/llama/modeling.py
Codecov / codecov/patch
paddlenlp/transformers/llama/modeling.py#L632
Check warning on line 634 in paddlenlp/transformers/llama/modeling.py
Codecov / codecov/patch
paddlenlp/transformers/llama/modeling.py#L634
Check warning on line 750 in paddlenlp/transformers/llama/modeling.py
Codecov / codecov/patch
paddlenlp/transformers/llama/modeling.py#L750
Check warning on line 752 in paddlenlp/transformers/llama/modeling.py
Codecov / codecov/patch
paddlenlp/transformers/llama/modeling.py#L752
Check warning on line 759 in paddlenlp/transformers/llama/modeling.py
Codecov / codecov/patch
paddlenlp/transformers/llama/modeling.py#L759
Check warning on line 761 in paddlenlp/transformers/llama/modeling.py
Codecov / codecov/patch
paddlenlp/transformers/llama/modeling.py#L761