Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support qwen dpo fused kernel #9686

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

wtmlon
Copy link
Collaborator

@wtmlon wtmlon commented Dec 24, 2024

PR types

PR changes

Description

dpo支持 fused kernel 配置

Copy link

paddle-bot bot commented Dec 24, 2024

Thanks for your contribution!

Copy link
Contributor

@lugimzzz lugimzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +114 to +117
use_fused_rms_norm=training_args.use_fused_rms_norm,
use_fused_rope=training_args.use_fused_rope,
use_fused_linear=training_args.use_fused_linear,
use_fused_dropout_add=training_args.use_fused_dropout_add,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以用 llm meta config, set_config 避免复杂的赋值操作。也可以不用

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.01%. Comparing base (801682d) to head (e62333d).
Report is 13 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9686      +/-   ##
===========================================
+ Coverage    52.34%   53.01%   +0.66%     
===========================================
  Files          726      718       -8     
  Lines       117265   112297    -4968     
===========================================
- Hits         61377    59529    -1848     
+ Misses       55888    52768    -3120     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wtmlon wtmlon merged commit 07ad5e6 into PaddlePaddle:develop Dec 30, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants