Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[llm]support dpo pp for qwen & llama #9695

Merged
merged 3 commits into from
Dec 27, 2024
Merged

Conversation

lugimzzz
Copy link
Contributor

PR types

New features

PR changes

Others

Description

支持pp

Copy link

paddle-bot bot commented Dec 25, 2024

Thanks for your contribution!

wawltor
wawltor previously approved these changes Dec 25, 2024
Copy link
Collaborator

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 18.24818% with 112 lines in your changes missing coverage. Please review.

Project coverage is 52.71%. Comparing base (801682d) to head (d5bb5d0).
Report is 12 commits behind head on develop.

Files with missing lines Patch % Lines
paddlenlp/transformers/kto_criterion.py 12.71% 103 Missing ⚠️
paddlenlp/transformers/llama/modeling_pp.py 25.00% 3 Missing ⚠️
paddlenlp/transformers/qwen/modeling_pp.py 40.00% 3 Missing ⚠️
paddlenlp/transformers/qwen2/modeling_pp.py 40.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9695      +/-   ##
===========================================
+ Coverage    52.34%   52.71%   +0.37%     
===========================================
  Files          726      719       -7     
  Lines       117265   112504    -4761     
===========================================
- Hits         61377    59310    -2067     
+ Misses       55888    53194    -2694     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit 79695cc into PaddlePaddle:develop Dec 27, 2024
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants