Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove json parse from unsafe code #121

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

t1agob
Copy link
Contributor

@t1agob t1agob commented Jul 23, 2024

Description

This PR refactors areas where JSON.parse was used in unsafe code which leaves the potential for unexpected exceptions.

It also bumps Backstage package versions.

Issue number: N/A

Type of change

  • New feature (non-breaking change which adds functionality)
  • Fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have performed a self-review of this change
  • Changes have been tested
  • Changes are documented
  • Changes generate no new warnings
  • PR title follows conventional commit semantics

If this is a breaking change 👇

  • I have documented the migration process
  • I have implemented necessary warnings (if it can live side by side)

Acknowledgement

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@t1agob t1agob added enhancement New feature or request dependencies Pull requests that update a dependency file labels Jul 23, 2024
@t1agob t1agob merged commit 0110628 into next Jul 23, 2024
4 checks passed
@t1agob t1agob deleted the chore/remove-json-parse-from-unsafe-code branch July 23, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant