Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing subheaders from lists #15

Merged
merged 2 commits into from
Sep 18, 2023
Merged

Removing subheaders from lists #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ab20d8
style: :lipstick: removing subheaders from lists
t1agob Sep 18, 2023
b30c7d2
fix: :fire: fixing issue with components not being used
t1agob Sep 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/ChangeEvents/ChangeEvents.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

// eslint-disable-next-line @backstage/no-undeclared-imports
import React, { useEffect } from 'react';
import { List, ListSubheader } from '@material-ui/core';
import { List } from '@material-ui/core';
import { ChangeEventListItem } from './ChangeEventListItem';
import { ChangeEventEmptyState } from './ChangeEventEmptyState';
import useAsyncFn from 'react-use/lib/useAsyncFn';
Expand Down Expand Up @@ -61,7 +61,7 @@ export const ChangeEvents = ({ serviceId, refreshEvents }: Props) => {
}

return (
<List dense subheader={<ListSubheader>CHANGE EVENTS</ListSubheader>}>
<List dense>
{changeEvents!.map((changeEvent, index) => (
<ChangeEventListItem
key={changeEvent.id + index}
Expand Down
4 changes: 2 additions & 2 deletions src/components/Incident/Incidents.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
*/
// eslint-disable-next-line @backstage/no-undeclared-imports
import React, { useEffect } from 'react';
import { List, ListSubheader } from '@material-ui/core';
import { List } from '@material-ui/core';
import { IncidentListItem } from './IncidentListItem';
import { IncidentsEmptyState } from './IncidentEmptyState';
import useAsyncFn from 'react-use/lib/useAsyncFn';
Expand Down Expand Up @@ -63,7 +63,7 @@ export const Incidents = ({ serviceId, refreshIncidents }: Props) => {
}

return (
<List dense subheader={<ListSubheader>INCIDENTS</ListSubheader>}>
<List dense>
{incidents!.map((incident, index) => (
<IncidentListItem key={incident.id + index} incident={incident} />
))}
Expand Down