Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: 0.9.3 #79

Merged
merged 2 commits into from
Mar 1, 2024
Merged

release: 0.9.3 #79

merged 2 commits into from
Mar 1, 2024

Commits on Mar 1, 2024

  1. fix: remove config definitions that are secret

    Signed-off-by: Alec Jacobs <[email protected]>
    alecjacobs5401 committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    216b68c View commit details
    Browse the repository at this point in the history
  2. fix: remove config definitions that are secret (#78)

    ### Description
    
    Removes the `pagerDuty.apiToken` and `pagerDuty.oauth` configuration
    definitions from this repository as they should be treated as secret
    config and this frontend plugin does not need to know about them.
    
    See PagerDuty/backstage-plugin-backend#36 for a
    related PR to mark those configuration values as secret.
    
    ### Type of change
    
    - [ ] New feature (non-breaking change which adds functionality)
    - [x] Fix (non-breaking change which fixes an issue)
    - [ ] Breaking change (fix or feature that would cause existing
    functionality to not work as expected)
    
    ### Checklist
    
    - [x] I have performed a self-review of this change
    - [x] Changes have been tested
    - [x] Changes are documented
    - [x] Changes generate *no new warnings*
    - [x] PR title follows [conventional commit
    semantics](https://www.conventionalcommits.org/en/v1.0.0/)
    
    If this is a breaking change 👇
    
    - [ ] I have documented the migration process
    - [ ] I have implemented necessary warnings (if it can live side by
    side)
    
    ## Acknowledgement
    
    By submitting this pull request, I confirm that you can use, modify,
    copy, and redistribute this contribution, under the terms of your
    choice.
    
    **Disclaimer:** We value your time and bandwidth. As such, any pull
    requests created on non-triaged issues might not be successful.
    t1agob authored Mar 1, 2024
    Configuration menu
    Copy the full SHA
    817c87c View commit details
    Browse the repository at this point in the history