feat: hide trigger incident on missing integration key #88
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a behaviour change when the
integration key
is missing from an entity configuration. Currently the behaviour is to disable the button but keep it on the screen.After discussing the plugin with several customers, many shared with us that they don't want people to manually create incidents from Backstage as incidents are automatically created from alerts. Therefore we decided to remove the button if the integration key is not provided as part of the entity configuration, like we already do when the
readonly
parameter is passed to the PagerDutyCard.This also allows us to save some valuable space in the PagerDutyCard.
Issue number: #67
Type of change
Checklist
If this is a breaking change 👇
Acknowledgement
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.