Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a quick foreground flag. #94

Closed
wants to merge 1 commit into from
Closed

Conversation

cdegroot
Copy link
Contributor

If we get more command line arguments, we need to add a proper
getopts setup, but for now this suffices.

Should satisfy #92

If we get more command line arguments, we need to add a proper
getopts setup, but for now this suffices.
@divtxt
Copy link
Contributor

divtxt commented Jul 2, 2015

Looks good. I want to be stricter about the args but it's not worth more than one line at this time.

nit: skipping daemonize also skips the pid file check & writing, which preventing two agents from running and from using init script stop. not sure that's worth fixing at this time either. :)

@phlegx
Copy link

phlegx commented Nov 18, 2015

@divtxt @ALL

Has the "-f" flag be removed again from the master?

For running it within docker and supervisor, one would need to run this in foreground.

@divtxt
Copy link
Contributor

divtxt commented Nov 18, 2015

@phlegx - we never merged the "-f" flag in master.

We're not planning an official release at this time. You can use this branch or patch your agent install manually for this.

@spkane
Copy link

spkane commented Oct 5, 2016

@divtxt Please consider merging this (or something similar). It is becoming much more common to be running Nagios in environments that use supervisors that need non-daemonizing processes.

Trying to troubleshoot the issue, track down this PR, patch our build process, test, and iterate, is a lot more trouble for folks then applying something like this, and noting in the setup instructions that this switch can be used for environments like supervisord and systemd that don't expect their processes to daemonize.

@mlewis033
Copy link
Contributor

Implemented with #100

@mlewis033 mlewis033 closed this Dec 2, 2016
@bzmw bzmw deleted the issue-92-add-foreground-flag branch January 15, 2020 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants