-
-
Notifications
You must be signed in to change notification settings - Fork 749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for linking Volunteer/Groups/Membership & Integrated with Action Items #2602
Conversation
Caution Review failedThe pull request is closed. WalkthroughThe changes in this pull request enhance the GraphQL schema and related models to support volunteer, group, and membership functionalities. Key modifications include the addition of new types, input types, and enums for managing volunteer memberships, as well as updates to existing types and resolvers to accommodate these changes. Several resolvers and queries have been refactored to improve filtering and sorting capabilities. Additionally, new utility functions have been introduced for checking the existence of users and volunteers, and various test files have been updated to align with the new data structures and functionalities. Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant Resolver
participant Database
Client->>Resolver: createVolunteerMembership(args)
Resolver->>Database: checkUserExists(userId)
Database-->>Resolver: User found
Resolver->>Database: checkEventExists(eventId)
Database-->>Resolver: Event found
Resolver->>Database: createVolunteerMembership(args)
Database-->>Resolver: Membership created
Resolver-->>Client: Return membership
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
What kind of change does this PR introduce?
feature, refactoring
Issue Number:
Fixes #2585
Did you add tests for your changes?
Yes
Summary
VolunteerMembership
Model to handle request/invitation for volunteer groupsDoes this PR introduce a breaking change?
No
Other information
Have you read the contributing guide?
Yes
Summary by CodeRabbit
Release Notes
New Features
VolunteerMembership
model for managing volunteer memberships.getEventVolunteers
,getVolunteerMembership
, andactionItemsByUser
.Improvements
Bug Fixes
Tests