Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct bytes sent/received field aliases for pan:firewall_cloud #260

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ryanbsaunders
Copy link

@ryanbsaunders ryanbsaunders commented Jul 29, 2022

Description

Flip the bytes_in and bytes_out field aliases.

Motivation and Context

'bytes_in' should be mapped to the BytesReceived field from the perspective of the client in a client-to-server connection. Currently, bytes_in is evaluated from the perspective of the server.

How Has This Been Tested?

This change was tested and evaluated in my organization's Splunk environment using log events from Cortex Data Lake/Prisma Access. We were able to confirm that the change provides the expected mapping of BytesReceived and BytesSent to CIM-compliant fields.

This change was also evaluated using the existing built-in tests.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@welcome-to-palo-alto-networks

🎉 Thanks for opening this pull request! We really appreciate contributors like you! 🙌

@btorresgil btorresgil self-requested a review October 7, 2022 15:23
@btorresgil btorresgil self-assigned this Oct 7, 2022
@paulmnguyen paulmnguyen force-pushed the develop branch 2 times, most recently from de4dfdc to d7bd687 Compare May 17, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants