Fix errors from version 0.8.1 #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve more deprecated Job.exc_info references
|
I just noticed that the tests are not actually run in GitHub Actions because the actual testing step is always skipped. Is that intended? I can ensure that the tests did succeed on this PR and on the previous PR. |
|
I have re-enabled the tests for testing with every currently supported python version. |
|
@jvllmr that was probably due to some issue but the new ones are working and I enabled them as mandatory merging this and releasing, thanks for the works |
cjlapao
approved these changes
Oct 30, 2024
|
@jvllmr this is now released as 0.8.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Unfortunately, I messed up in my PR #495 and introduced erroring code due to inadequate testing.
I fixed the errors and implemented tests for the missing endpoints to catch errors earlier.
I also accidentally stringified None to "None" for exc_info, causing every non-failing job to show a literal "None" in the exc_info block.
Type of change
Please delete options that are not relevant.
Checklist: