Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add video duration & Color Customisability #15

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

joeShuff
Copy link

@joeShuff joeShuff commented Oct 3, 2019

This branch adds the duration of a video to the picker media item. It only shows if it's media type is MediaType.VIDEO and is loaded using the MediaMetadataRetriever.

@joeShuff
Copy link
Author

joeShuff commented Oct 4, 2019

I have also added the following attributes to the builder:
toolbarColor - Change the color of the toolbar (Default: White)
titleTextColor - Change the color of the title in the toolbar (Default: Black)
backButtonColor - Change the color of the back button in the toolbar (Default: Black)

I'm not sure whether you'd prefer these different changes in different branches or not. Just let me know if you'd like me to separate them into different merge requests.

@joeShuff joeShuff changed the title Add video duration Add video duration & Color Customisability Oct 4, 2019
@joeShuff
Copy link
Author

This branch is ready to merge @ParkSangGwon

@ParkSangGwon
Copy link
Owner

@joeShuff
Sorry, I checked late..
Please make merge commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants