Skip to content

Commit

Permalink
Upgrade to Choices.js 11 (#273)
Browse files Browse the repository at this point in the history
They fixed a CSS bug we had a workaround for.
  • Loading branch information
Eric-Arellano authored Aug 31, 2024
1 parent 94d46cb commit b2fb03d
Show file tree
Hide file tree
Showing 5 changed files with 26 additions and 59 deletions.
68 changes: 19 additions & 49 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,8 @@
"@fortawesome/free-regular-svg-icons": "^6.5.2",
"@fortawesome/free-solid-svg-icons": "^6.5.2",
"@parcel/resolver-glob": "^2.10.3",
"choices.js": "^10.2.0",
"leaflet": "~1.9.3",
"ts-results": "^3.3.0"
"choices.js": "^11.0.1",
"leaflet": "~1.9.3"
},
"devDependencies": {
"@parcel/compressor-brotli": "^2.10.3",
Expand All @@ -43,6 +42,7 @@
"playwright": "^1.34.3",
"prettier": "^3.3.3",
"ts-node": "^10.9.2",
"ts-results": "^3.3.0",
"typescript": "^5.3.3"
},
"targets": {
Expand Down
2 changes: 2 additions & 0 deletions scripts/add-city.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
/* eslint-disable import/no-extraneous-dependencies */

import results from "ts-results";
import fs from "fs/promises";
import { determineArgs, updateCoordinates, updateParkingLots } from "./base.ts";
Expand Down
2 changes: 2 additions & 0 deletions scripts/base.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
/* eslint-disable import/no-extraneous-dependencies */

import results from "ts-results";
import fs from "fs/promises";
import {
Expand Down
7 changes: 0 additions & 7 deletions src/css/_dropdown.scss
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,3 @@ div.choices__item.choices__item--choice.choices__item--selectable {
z-index: zindex.$dropdown;
color: colors.$black;
}

.choices__list--dropdown .choices__item--selectable,
.choices__list[aria-expanded] .choices__item--selectable {
// Choices.js sets this to 100px to account for itemSelectText. But we disable that,
// so we want to use the normal padding it would otherwise use of 10px.
padding-right: 10px;
}

0 comments on commit b2fb03d

Please sign in to comment.