Skip to content

Commit

Permalink
Upgrade to newest version of Playwright (#137)
Browse files Browse the repository at this point in the history
Playwright 1.38 no longer installs the browsers for you:
https://github.com/microsoft/playwright/releases/tag/v1.38.0.

Local users should rerun the below:

```
npm install
npx playwright install
```
  • Loading branch information
Eric-Arellano authored Feb 11, 2024
1 parent f5dd0c1 commit f16f448
Show file tree
Hide file tree
Showing 4 changed files with 1,706 additions and 1,247 deletions.
4 changes: 3 additions & 1 deletion .github/workflows/deploy-staging.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@ jobs:
with:
node-version: 18
- name: Install dependencies
run: npm ci
run: |
npm ci
npx playwright install --with-deps
- name: Build
run: npm run build
- name: Run tests on dist/
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@ jobs:
with:
node-version: 18
- name: Install dependencies
run: npm ci
run: |
npm ci
npx playwright install --with-deps
- name: Lint
run: npm run lint
- name: Run tests
Expand Down
9 changes: 9 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,15 @@ You will also need to install:

To run the below commands, open your terminal app. Make sure you have `git clone`d the fork of your repository somewhere on your machine. Then, use `cd <directory>` to navigate there, e.g. `cd code/parking-lot-map`.

## Prereq: install

You must first install the project's dependencies before running any of the below commands.

```bash
❯ npm install
❯ npx playwright install
```

## Start the server

```bash
Expand Down
Loading

0 comments on commit f16f448

Please sign in to comment.