Improve attribution #124
Merged
Improve attribution #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Arellano
added a commit
to ParkingReformNetwork/reform-map
that referenced
this pull request
Aug 20, 2023
Close #192 and similar to ParkingReformNetwork/parking-lot-map#124.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #123.
Before:
After:
This gives better attribution in our info popup, which we should have always been doing. It also simplifies the on-map attribution so that it's more concise, which is valuable to take up less space. Note that OSM guidelines say we do indeed need to keep their attribution on the map itself: https://wiki.osmfoundation.org/wiki/Licence/Attribution_Guidelines.