Replacing current dropdown with choices.js select-one that enables search within dropdown list #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Alankvuong
commented
Oct 4, 2023
Alankvuong
commented
- Added some css for mobile that maintained the same formatting prior to this change
- Added a setUpSearch function in setUpSite.js that enables the use of Choices
…arch within dropdown list
tunglinn
reviewed
Oct 4, 2023
|
As for the failed check, try |
…lready implemented
|
Looks good, just have to fix the check! |
… comment to disable error for 'no-unused-vars'
|
This ended up getting implemented in #176. Thank you, Alan, for getting this started! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.