Clicking on city boundary will pull up scorecard #139
Conversation
|
Birmingham was added to |
| @@ -571,67 +571,69 @@ | |||
| "id": "birmingham-al" | |||
| }, | |||
| "geometry": { | |||
| "type": "LineString", | |||
There was a problem hiding this comment.
Good find. Looks like this is the only instance of it.
src/js/setUpSite.js
Outdated
| cityToggleElement.value = cityId; | ||
| setMapToCity(map, cityId, cities[cityId]); |
There was a problem hiding this comment.
Ik this is still a draft so pardon if this is premature. We'll still want to only do this if the zoom is a certain value. Otherwise clicking on the city from zoomed out will be noisy.
There was a problem hiding this comment.
When you click a city, it zooms in onto the city (similar to if you select it from the dropdown). I think this resolves the noise you're talking about?
There was a problem hiding this comment.
Not quite. Imagine you're super zoomed out on the map, so the cities are tiny dots. You click on it because let's say you're on a phone and the touch targets aren't big—but really you were just trying to zoom in or move around the map!
We should only change the city if the zoom level is below a certain threshold.
|
👏 |
<path>for city boundary now has an id attributeCurrent map zoom required to allow click is 7, which looks like this.
And, this zoom and beyond will not allow you to click on cities.
