Fully implement lazy loading #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next step is to get the map to render using the split files. Co-authored-by: tunglinn <[email protected]>
Mostly to get the autoscord card update, to help with lazy loading. --------- Co-authored-by: Eric Arellano <[email protected]> Co-authored-by: tunglinn <[email protected]>
Right now, parking lots will only load if you use the dropdown. However, a better implementation is to "Load when dragged into view". Might wait for #143 to implement. To-do: - [x] Load when dragged into view - [x] Tests --------- Co-authored-by: tunglinn <[email protected]>
Add tests --------- Co-authored-by: tunglinn <[email protected]>
src/js/setUpSite.js
Outdated
Comment on lines
172
to
174
| if (loadedCity.feature.properties.id === cityId) { | ||
| load = false; | ||
| } |
There was a problem hiding this comment.
I don't follow this. Instead, should the logic be
const city = parkingLayer.getLayers().find((city) => city.feature.properties.id == cityId);
load = city.feature.properties.<something>Right now, this seems like it will always reload the same city no matter what, even if it was loaded before.
There was a problem hiding this comment.
parkingLayer is the layer of already loaded lots.
So the logic right now is, if the city we want to load is already loaded (aka in parkingLayer), then don't load it.
| @@ -246,3 +246,33 @@ test("scorecard pulls up city closest to center", async ({ page }) => { | |||
| await expect(scoreCardTitle).toEqual("Birmingham, AL"); | |||
| await expect(cityToggleValue).toEqual("birmingham-al"); | |||
| }); | |||
|
|
|||
| test("map only loads parking lots for visible cities", async ({ page }) => { | |||
There was a problem hiding this comment.
Great job testing this!
scripts/base.js
Outdated
| const newCoordinates = newData.features[0].geometry.coordinates; | ||
| const newGeometryType = newData.features[0].geometry.type; | ||
|
|
||
| if (addCity) { |
There was a problem hiding this comment.
Better is to invert the conditional and early return, like:
if (!addCity) {
return
}
const newFile = ...
See https://medium.com/swlh/return-early-pattern-3d18a41bba8 about this tip.
This reverts commit 2008de9.
Eric-Arellano
approved these changes
Feb 4, 2024
src/js/setUpSite.js
Outdated
| * | ||
| * @param map: The Leaflet map instance. | ||
| */ | ||
| const setUpParkingparkingLayer = async (map) => { |
There was a problem hiding this comment.
Typo in the function name?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parking lot data is now split by city, to allow for lazy loading.
Parking lots will only be loaded if the city is within view.
Added testing.