Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further improve design of left controls #200

Conversation

Eric-Arellano
Copy link
Contributor

Follow up to #199.

  • Uses touch target 44 x 44px, not 40 x 40px. On my iPhone, 40 x 40px is still fairly small. Now, we follow the web accessibility standard.
  • Increases the size of the layers touch targets to 44px height. To make the touch targets look distinct and not have weird space in the middle, I added a 1px border, which mirrors the zoom-in and out buttons.
  • Uses our colors for all the borders. I still don't love the color, but it can be changed later. This at least switches to our own color
  • Consistently use font-size-md and non-bold text
  • Vertically aligns radio buttons with label text
  • Renames "Light" layer to "High contrast" for better clarity

Ideas for additional improvement:

  • prettier radio button
  • choose a better border color
before (before #199) Screenshot 2024-07-01 at 10 45 01 PM
before (with #199) Screenshot 2024-07-01 at 10 43 57 PM
after Screenshot 2024-07-02 at 8 31 27 AM

@Eric-Arellano Eric-Arellano merged commit 4a5f616 into ParkingReformNetwork:main Jul 2, 2024
1 check passed
@Eric-Arellano Eric-Arellano deleted the EA/bigger-touch-target branch July 2, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant