Skip to content
This repository has been archived by the owner on Mar 24, 2021. It is now read-only.

fix broken version comparison used during ssl tests #682

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

emmettbutler
Copy link
Contributor

@emmettbutler emmettbutler commented May 16, 2017

This pull request fixes a version comparison operation that caused ssl tests not to run under kafka 0.10.

@codecov-io
Copy link

codecov-io commented May 16, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@26ce1c0). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #682   +/-   ##
=========================================
  Coverage          ?   81.25%           
=========================================
  Files             ?       25           
  Lines             ?     3302           
  Branches          ?      485           
=========================================
  Hits              ?     2683           
  Misses            ?      479           
  Partials          ?      140
Impacted Files Coverage Δ
pykafka/connection.py 77.65% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26ce1c0...f273b6a. Read the comment docs.

@emmettbutler
Copy link
Contributor Author

See the travis runs on this branch - ssl connections are currently failing with dh key is too small.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants