Skip to content
This repository has been archived by the owner on Mar 24, 2021. It is now read-only.

Fix tests for librdkafka 0.11.3+ #928

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

carsonip
Copy link
Contributor

@carsonip carsonip commented Mar 17, 2019

Limit queued.max.messages.kbytes according to librdkafka confluentinc/librdkafka@cc43f45.

This will fix rdkafka tests on librdkafka 0.11.3+.

E       RdKafkaException: Configuration property "queued.max.messages.kbytes" value 102400000 is outside allowed range 1..2097151

Limit queued.max.messages.kbytes according to librdkafka cc43f4
@codecov-io
Copy link

codecov-io commented Mar 17, 2019

Codecov Report

Merging #928 into master will increase coverage by 0.6%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #928     +/-   ##
=========================================
+ Coverage   83.21%   83.81%   +0.6%     
=========================================
  Files          36       36             
  Lines        3806     3807      +1     
  Branches      562      562             
=========================================
+ Hits         3167     3191     +24     
+ Misses        490      472     -18     
+ Partials      149      144      -5
Impacted Files Coverage Δ
pykafka/rdkafka/simple_consumer.py 89.47% <100%> (+0.09%) ⬆️
pykafka/handlers.py 91.17% <0%> (-1.48%) ⬇️
pykafka/balancedconsumer.py 90.05% <0%> (+0.29%) ⬆️
pykafka/broker.py 94.21% <0%> (+1.15%) ⬆️
pykafka/topic.py 80.41% <0%> (+2.06%) ⬆️
pykafka/cluster.py 73.62% <0%> (+2.19%) ⬆️
pykafka/simpleconsumer.py 87.05% <0%> (+2.45%) ⬆️
pykafka/connection.py 86.13% <0%> (+2.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3893c46...04d3c2e. Read the comment docs.

pykafka/rdkafka/simple_consumer.py Outdated Show resolved Hide resolved
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants