Skip to content
This repository has been archived by the owner on Mar 24, 2021. It is now read-only.

add private method __getHost for setup default port to 9092 #948

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

morgangt
Copy link

i am fixed how could #870 this my version realization
if it's ok i resume commits if there is remarks I'll correct

@codecov-io
Copy link

codecov-io commented May 30, 2019

Codecov Report

Merging #948 into master will increase coverage by 0.04%.
The diff coverage is 10.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #948      +/-   ##
==========================================
+ Coverage   83.50%   83.54%   +0.04%     
==========================================
  Files          36       36              
  Lines        3807     3817      +10     
  Branches      562      565       +3     
==========================================
+ Hits         3179     3189      +10     
  Misses        483      483              
  Partials      145      145              
Impacted Files Coverage Δ
pykafka/client.py 66.66% <10.00%> (-21.80%) ⬇️
pykafka/connection.py 85.14% <0.00%> (-1.99%) ⬇️
pykafka/simpleconsumer.py 85.49% <0.00%> (-0.90%) ⬇️
pykafka/cluster.py 72.26% <0.00%> (+0.72%) ⬆️
pykafka/balancedconsumer.py 90.93% <0.00%> (+1.75%) ⬆️
pykafka/managedbalancedconsumer.py 86.75% <0.00%> (+2.64%) ⬆️
pykafka/topic.py 82.47% <0.00%> (+3.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0c6929...9036f3b. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants