Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LCSCProvider field for real datasheet URL #670

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

frank-f
Copy link
Contributor

@frank-f frank-f commented Aug 20, 2024

I noticed, that LCSC changed the field containing the URL to the real datasheet.

I updated the LCSCProvider method accordingly.

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 62.30%. Comparing base (a169623) to head (1964848).
Report is 1 commits behind head on master.

Files Patch % Lines
...ices/InfoProviderSystem/Providers/LCSCProvider.php 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #670      +/-   ##
============================================
- Coverage     62.31%   62.30%   -0.02%     
  Complexity     5656     5656              
============================================
  Files           518      518              
  Lines         18695    18695              
============================================
- Hits          11650    11647       -3     
- Misses         7045     7048       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jbtronics
Copy link
Member

Thank you

@jbtronics jbtronics merged commit fd521ac into Part-DB:master Aug 21, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants