Skip to content

Commit

Permalink
Remove unneeded ToTransportAddress override
Browse files Browse the repository at this point in the history
  • Loading branch information
kentdr committed Sep 1, 2023
1 parent d2ae4bf commit 1ec007f
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 16 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -93,11 +93,6 @@ namespace NServiceBus
public void MapEvent<TSubscribedEvent>(System.Collections.Generic.IEnumerable<string> customTopicsNames) { }
public void MapEvent<TSubscribedEvent>(string customTopicName) { }
public void MapEvent<TSubscribedEvent, TPublishedEvent>() { }
[System.Obsolete("Inject the ITransportAddressResolver type to access the address translation mecha" +
"nism at runtime. See the NServiceBus version 8 upgrade guide for further details" +
". The member currently throws a NotImplementedException. Will be removed in vers" +
"ion 8.0.0.", true)]
public override string ToTransportAddress(NServiceBus.Transport.QueueAddress address) { }
}
public static class SqsTransportSettings
{
Expand Down
11 changes: 0 additions & 11 deletions src/NServiceBus.Transport.SQS/obsoletes-v7.cs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ namespace NServiceBus
{
using System;
using Amazon.S3;
using NServiceBus.Transport;

public static partial class SqsTransportSettings
{
Expand Down Expand Up @@ -89,16 +88,6 @@ public void AddNamespaceCondition(string topicNamespace)

public partial class SqsTransport
{
[ObsoleteEx(Message = "Inject the ITransportAddressResolver type to access the address translation mechanism at runtime. See the NServiceBus version 8 upgrade guide for further details.",
TreatAsErrorFromVersion = "7",
RemoveInVersion = "8")]
#pragma warning disable CS0672 // Member overrides obsolete member
public override string ToTransportAddress(QueueAddress address)
#pragma warning restore CS0672 // Member overrides obsolete member
{
throw new NotImplementedException();
}

[ObsoleteEx(
Message = "The SQS transport no longer supports 1.x compatibility mode",
TreatAsErrorFromVersion = "7",
Expand Down

0 comments on commit 1ec007f

Please sign in to comment.