Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Obsoletes update #2272

Closed
wants to merge 2 commits into from
Closed

Obsoletes update #2272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
abfb598
Update NServiceBus to 9.0.0-alpha.2
kentdr Sep 1, 2023
9d3b565
Remove unneeded ToTransportAddress override
kentdr Sep 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...ServiceBus.Transport.SQS.AcceptanceTests/NServiceBus.Transport.SQS.AcceptanceTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<Project Sdk="Microsoft.NET.Sdk">
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net8.0</TargetFramework>
Expand All @@ -18,7 +18,7 @@
<PackageReference Include="BitFaster.Caching" Version="2.2.1" />
<PackageReference Include="GitHubActionsTestLogger" Version="2.3.3" />
<PackageReference Include="NServiceBus.AcceptanceTests.Sources" Version="9.0.0-alpha.2" GeneratePathProperty="true" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.8.0-preview-23424-02" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.8.0-preview-23371-04" />
<PackageReference Include="NUnit" Version="3.13.3" />
<PackageReference Include="NUnit3TestAdapter" Version="4.5.0" />
</ItemGroup>
Expand Down
5 changes: 0 additions & 5 deletions ...erviceBus.Transport.SQS.Tests/ApprovalFiles/APIApprovals.ApproveSqsTransport.approved.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,11 +93,6 @@ namespace NServiceBus
public void MapEvent<TSubscribedEvent>(System.Collections.Generic.IEnumerable<string> customTopicsNames) { }
public void MapEvent<TSubscribedEvent>(string customTopicName) { }
public void MapEvent<TSubscribedEvent, TPublishedEvent>() { }
[System.Obsolete("Inject the ITransportAddressResolver type to access the address translation mecha" +
"nism at runtime. See the NServiceBus version 8 upgrade guide for further details" +
". The member currently throws a NotImplementedException. Will be removed in vers" +
"ion 8.0.0.", true)]
public override string ToTransportAddress(NServiceBus.Transport.QueueAddress address) { }
}
public static class SqsTransportSettings
{
Expand Down
2 changes: 1 addition & 1 deletion src/NServiceBus.Transport.SQS.Tests/NServiceBus.Transport.SQS.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<Project Sdk="Microsoft.NET.Sdk">
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net8.0</TargetFramework>
Expand Down
4 changes: 2 additions & 2 deletions src/NServiceBus.Transport.SQS.TransportTests/NServiceBus.Transport.SQS.TransportTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<Project Sdk="Microsoft.NET.Sdk">
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net8.0</TargetFramework>
Expand All @@ -17,7 +17,7 @@
<PackageReference Include="AWSSDK.S3" Version="3.7.203.4" />
<PackageReference Include="BitFaster.Caching" Version="2.2.1" />
<PackageReference Include="GitHubActionsTestLogger" Version="2.3.3" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.8.0-preview-23424-02" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.8.0-preview-23371-04" />
<PackageReference Include="NServiceBus.TransportTests.Sources" Version="9.0.0-alpha.2" GeneratePathProperty="true" />
<PackageReference Include="NUnit" Version="3.13.3" />
<PackageReference Include="NUnit3TestAdapter" Version="4.5.0" />
Expand Down
11 changes: 0 additions & 11 deletions src/NServiceBus.Transport.SQS/obsoletes-v7.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ namespace NServiceBus
{
using System;
using Amazon.S3;
using NServiceBus.Transport;

public static partial class SqsTransportSettings
{
Expand Down Expand Up @@ -89,16 +88,6 @@ public void AddNamespaceCondition(string topicNamespace)

public partial class SqsTransport
{
[ObsoleteEx(Message = "Inject the ITransportAddressResolver type to access the address translation mechanism at runtime. See the NServiceBus version 8 upgrade guide for further details.",
TreatAsErrorFromVersion = "7",
RemoveInVersion = "8")]
#pragma warning disable CS0672 // Member overrides obsolete member
public override string ToTransportAddress(QueueAddress address)
#pragma warning restore CS0672 // Member overrides obsolete member
{
throw new NotImplementedException();
}

[ObsoleteEx(
Message = "The SQS transport no longer supports 1.x compatibility mode",
TreatAsErrorFromVersion = "7",
Expand Down