Skip to content

Commit

Permalink
Obsolete the PreObsoletes
Browse files Browse the repository at this point in the history
  • Loading branch information
kentdr committed Sep 14, 2023
1 parent 299537b commit d19689a
Showing 1 changed file with 4 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@ internal CompatibilitySettings(SettingsHolder settings) : base(settings)
/// Once all sagas have been migrated from version 2.4.x of the persister to the current version the lookup can be disabled no longer calling this method.
/// All migrated sagas do not contain a row called NServiceBus_2ndIndexKey
/// </summary>
[PreObsolete("https://github.com/Particular/NServiceBus.Persistence.AzureTable/issues/836",
Note = "Following our breaking change guidelines, the compatibility mode should be removed at some point after making it opt-in.")]
[ObsoleteEx(Message = "Compatibility mode is deprecated and will be removed in future versions.", RemoveInVersion = "8.0", TreatAsErrorFromVersion = "7.0")]
public void EnableSecondaryKeyLookupForSagasCorrelatedByProperties()
{
var settings = this.GetSettings();
Expand All @@ -31,7 +30,7 @@ public void EnableSecondaryKeyLookupForSagasCorrelatedByProperties()
/// Opt-in to full table scanning for sagas that have been stored with version 1.4 or earlier.
/// </summary>
/// <remarks>Enabling this also requires enabling the compatibility mode by calling <see cref="EnableSecondaryKeyLookupForSagasCorrelatedByProperties"/></remarks>
[PreObsolete("https://github.com/Particular/NServiceBus.Persistence.AzureTable/issues/836", Note = "Following our breaking change guidelines, the compatibility mode should be removed at some point after making it opt-in.")]
[ObsoleteEx(Message = "Compatibility mode is deprecated and will be removed in future versions.", RemoveInVersion = "8.0", TreatAsErrorFromVersion = "7.0")]
public void AllowSecondaryKeyLookupToFallbackToFullTableScan()
{
var settings = this.GetSettings();
Expand All @@ -49,7 +48,7 @@ public void AllowSecondaryKeyLookupToFallbackToFullTableScan()
/// ensure all secondary index entries use RowKey = PartitionKey. By enabling this setting the secondary key lookups will assume RowKey = PartitionKey.
/// </summary>
/// <remarks>Enabling this also requires enabling the compatibility mode by calling <see cref="EnableSecondaryKeyLookupForSagasCorrelatedByProperties"/></remarks>
[PreObsolete("https://github.com/Particular/NServiceBus.Persistence.AzureTable/issues/836", Note = "Following our breaking change guidelines, the compatibility mode should be removed at some point after making it opt-in.")]
[ObsoleteEx(Message = "Compatibility mode is deprecated and will be removed in future versions.", RemoveInVersion = "8.0", TreatAsErrorFromVersion = "7.0")]
public void AssumeSecondaryKeyUsesANonEmptyRowKeySetToThePartitionKey()
{
var settings = this.GetSettings();
Expand All @@ -62,4 +61,4 @@ public void AssumeSecondaryKeyUsesANonEmptyRowKeySetToThePartitionKey()
settings.Set(WellKnownConfigurationKeys.SagaStorageAssumeSecondaryKeyUsesANonEmptyRowKeySetToThePartitionKey, true);
}
}
}
}

0 comments on commit d19689a

Please sign in to comment.