Merge pull request #342 from Particular/rename-previous-back

Remove copied sources from analysis
Particular · Nov 19, 2020 · d60e246 · d60e246
2 parents 8f539db + 24601df
commit d60e246
Show file tree

Hide file tree

Showing 18 changed files with 26 additions and 17 deletions.
diff --git a/src/Compatibility.StorageTable.AcceptanceTests/CompatibilityAcceptanceTest.cs b/src/Compatibility.StorageTable.AcceptanceTests/CompatibilityAcceptanceTest.cs
@@ -4,7 +4,7 @@ namespace NServiceBus.AcceptanceTests
     using System.Net;
     using System.Threading.Tasks;
     using Microsoft.Azure.Cosmos.Table;
-    using Persistence.AzureTable.Previous;
+    using Persistence.AzureTable.Release_2x;
     using Testing;
 
     public class CompatibilityAcceptanceTest : NServiceBusAcceptanceTest

diff --git a/...nceTests/Previous/CloudTableExtensions.cs → ...ests/Release_2x/CloudTableExtensions.g.cs b/...nceTests/Previous/CloudTableExtensions.cs → ...ests/Release_2x/CloudTableExtensions.g.cs
@@ -1,4 +1,4 @@
-namespace NServiceBus.Persistence.AzureTable.Previous
+namespace NServiceBus.Persistence.AzureTable.Release_2x
 {
     using System.Collections.Generic;
     using System.Linq;

diff --git a/...ceTests/Previous/DictionaryTableEntity.cs → ...sts/Release_2x/DictionaryTableEntity.g.cs b/...ceTests/Previous/DictionaryTableEntity.cs → ...sts/Release_2x/DictionaryTableEntity.g.cs
@@ -1,4 +1,4 @@
-namespace NServiceBus.Persistence.AzureTable.Previous
+namespace NServiceBus.Persistence.AzureTable.Release_2x
 {
     using System;
     using System.Collections;

diff --git a/...evious/DictionaryTableEntityExtensions.cs → ...e_2x/DictionaryTableEntityExtensions.g.cs b/...evious/DictionaryTableEntityExtensions.cs → ...e_2x/DictionaryTableEntityExtensions.g.cs
@@ -1,4 +1,4 @@
-namespace NServiceBus.Persistence.AzureTable.Previous
+namespace NServiceBus.Persistence.AzureTable.Release_2x
 {
     using System;
     using System.Collections.Generic;

diff --git a/...able.AcceptanceTests/Previous/LRUCache.cs → ....AcceptanceTests/Release_2x/LRUCache.g.cs b/...able.AcceptanceTests/Previous/LRUCache.cs → ....AcceptanceTests/Release_2x/LRUCache.g.cs
@@ -1,4 +1,4 @@
-namespace NServiceBus.Persistence.AzureTable.Previous
+namespace NServiceBus.Persistence.AzureTable.Release_2x
 {
     using System.Collections.Generic;
 

diff --git a/...nceTests/Previous/PartitionRowKeyTuple.cs → ...ests/Release_2x/PartitionRowKeyTuple.g.cs b/...nceTests/Previous/PartitionRowKeyTuple.cs → ...ests/Release_2x/PartitionRowKeyTuple.g.cs
@@ -1,4 +1,4 @@
-namespace NServiceBus.Persistence.AzureTable.Previous
+namespace NServiceBus.Persistence.AzureTable.Release_2x
 {
     using System;
     using Microsoft.Azure.Cosmos.Table;

diff --git a/src/Compatibility.StorageTable.AcceptanceTests/Release_2x/README.md b/src/Compatibility.StorageTable.AcceptanceTests/Release_2x/README.md
@@ -0,0 +1,9 @@
+We looked at several solutions like
+
+- Referencing the previous nuget package leveraging aliasing
+- Using a dedicated repository to verify backward compatibility
+- Spinning up custom app domains that load different assemblies
+
+One of the main goals was to make sure we are backward compatible and detect it early on master so a dedicated repository was ruled out. Custom aliasing didn't work out in the same acceptance test project and spinning up custom app domains was deemed too complex so we settled with a tradeoff of copying the previous saga persister code into master. In order for the code to not trigger analysis the files have been treated as external sources and use `.g.cs` as a file extension.
+
+The sources used only need to be updated if a patch version on the 2.4 branch introduced changes to the `DictionaryTableEntity` or the secondary index algorithm.
diff --git a/...tanceTests/Previous/SafeLinqExtensions.cs → ...eTests/Release_2x/SafeLinqExtensions.g.cs b/...tanceTests/Previous/SafeLinqExtensions.cs → ...eTests/Release_2x/SafeLinqExtensions.g.cs
@@ -1,4 +1,4 @@
-namespace NServiceBus.Persistence.AzureTable.Previous
+namespace NServiceBus.Persistence.AzureTable.Release_2x
 {
     using System.Collections.Generic;
     using System.Linq;

diff --git a/...tanceTests/Previous/SagaDataSerializer.cs → ...eTests/Release_2x/SagaDataSerializer.g.cs b/...tanceTests/Previous/SagaDataSerializer.cs → ...eTests/Release_2x/SagaDataSerializer.g.cs
@@ -1,4 +1,4 @@
-namespace NServiceBus.Persistence.AzureTable.Previous
+namespace NServiceBus.Persistence.AzureTable.Release_2x
 {
     using System;
     using System.Collections.Generic;

diff --git a/...ous/SagaPersisterUsingSecondaryIndexes.cs → ...x/SagaPersisterUsingSecondaryIndexes.g.cs b/...ous/SagaPersisterUsingSecondaryIndexes.cs → ...x/SagaPersisterUsingSecondaryIndexes.g.cs
@@ -1,4 +1,4 @@
-namespace NServiceBus.Persistence.AzureTable.Previous
+namespace NServiceBus.Persistence.AzureTable.Release_2x
 {
     using System;
     using System.Collections.Concurrent;

diff --git a/...ests/Previous/SecondaryIndexKeyBuilder.cs → .../Release_2x/SecondaryIndexKeyBuilder.g.cs b/...ests/Previous/SecondaryIndexKeyBuilder.cs → .../Release_2x/SecondaryIndexKeyBuilder.g.cs
@@ -1,4 +1,4 @@
-namespace NServiceBus.Persistence.AzureTable.Previous
+namespace NServiceBus.Persistence.AzureTable.Release_2x
 {
     using System;
     using System.IO;

diff --git a/...Tests/Previous/SecondaryIndexPersister.cs → ...s/Release_2x/SecondaryIndexPersister.g.cs b/...Tests/Previous/SecondaryIndexPersister.cs → ...s/Release_2x/SecondaryIndexPersister.g.cs
@@ -1,4 +1,4 @@
-namespace NServiceBus.Persistence.AzureTable.Previous
+namespace NServiceBus.Persistence.AzureTable.Release_2x
 {
     using System;
     using System.Net;

diff --git a/...sts/Previous/SecondaryIndexTableEntity.cs → ...Release_2x/SecondaryIndexTableEntity.g.cs b/...sts/Previous/SecondaryIndexTableEntity.cs → ...Release_2x/SecondaryIndexTableEntity.g.cs
@@ -1,4 +1,4 @@
-namespace NServiceBus.Persistence.AzureTable.Previous
+namespace NServiceBus.Persistence.AzureTable.Release_2x
 {
     using System;
     using Microsoft.Azure.Cosmos.Table;

diff --git a/src/Compatibility.StorageTable.AcceptanceTests/When_migrated_saga_completed.cs b/src/Compatibility.StorageTable.AcceptanceTests/When_migrated_saga_completed.cs
@@ -7,7 +7,7 @@ namespace NServiceBus.AcceptanceTests
     using EndpointTemplates;
     using NUnit.Framework;
     using Extensibility;
-    using Persistence.AzureTable.Previous;
+    using Persistence.AzureTable.Release_2x;
     using Sagas;
 
     public class When_migrated_saga_completed : CompatibilityAcceptanceTest

diff --git a/...tibility.StorageTable.AcceptanceTests/When_saga_migrated_and_transactionality_required.cs b/...tibility.StorageTable.AcceptanceTests/When_saga_migrated_and_transactionality_required.cs
@@ -9,7 +9,7 @@ namespace NServiceBus.AcceptanceTests
     using Extensibility;
     using Sagas;
     using Microsoft.Azure.Cosmos.Table;
-    using Persistence.AzureTable.Previous;
+    using Persistence.AzureTable.Release_2x;
     using Persistence.AzureTable;
     using Pipeline;
 

diff --git a/src/Compatibility.StorageTable.AcceptanceTests/When_saga_migrated_but_not_completed.cs b/src/Compatibility.StorageTable.AcceptanceTests/When_saga_migrated_but_not_completed.cs
@@ -7,7 +7,7 @@ namespace NServiceBus.AcceptanceTests
     using EndpointTemplates;
     using NUnit.Framework;
     using Extensibility;
-    using Persistence.AzureTable.Previous;
+    using Persistence.AzureTable.Release_2x;
     using Sagas;
 
     public class When_saga_migrated_but_not_completed : CompatibilityAcceptanceTest

diff --git a/src/Compatibility.StorageTable.AcceptanceTests/When_saga_migrated_with_modified_secondary.cs b/src/Compatibility.StorageTable.AcceptanceTests/When_saga_migrated_with_modified_secondary.cs
@@ -7,7 +7,7 @@ namespace NServiceBus.AcceptanceTests
     using EndpointTemplates;
     using NUnit.Framework;
     using Extensibility;
-    using Persistence.AzureTable.Previous;
+    using Persistence.AzureTable.Release_2x;
     using Sagas;
 
     public class When_saga_migrated_with_modified_secondary : CompatibilityAcceptanceTest

diff --git a/src/Compatibility.StorageTable.AcceptanceTests/When_saga_migrated_without_secondary.cs b/src/Compatibility.StorageTable.AcceptanceTests/When_saga_migrated_without_secondary.cs
@@ -8,7 +8,7 @@ namespace NServiceBus.AcceptanceTests
     using EndpointTemplates;
     using NUnit.Framework;
     using Extensibility;
-    using Persistence.AzureTable.Previous;
+    using Persistence.AzureTable.Release_2x;
     using Sagas;
 
     public class When_saga_migrated_without_secondary : CompatibilityAcceptanceTest