Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obsoletes update #1296

Merged
merged 2 commits into from
Aug 31, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="NServiceBus.AcceptanceTests.Sources" Version="9.0.0-alpha.1" GeneratePathProperty="true" />
<PackageReference Include="NServiceBus.AcceptanceTests.Sources" Version="9.0.0-alpha.2" GeneratePathProperty="true" />
<PackageReference Include="RabbitMQ.Client" Version="6.5.0" />
</ItemGroup>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="NServiceBus" Version="9.0.0-alpha.1" />
<PackageReference Include="NServiceBus" Version="9.0.0-alpha.2" />
<PackageReference Include="RabbitMQ.Client" Version="6.5.0" />
<PackageReference Include="System.CommandLine" Version="2.0.0-beta4.22272.1" />
</ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,6 @@ namespace NServiceBus
public void AddClusterNode(string hostName, int port, bool useTls) { }
public override System.Collections.Generic.IReadOnlyCollection<NServiceBus.TransportTransactionMode> GetSupportedTransactionModes() { }
public override System.Threading.Tasks.Task<NServiceBus.Transport.TransportInfrastructure> Initialize(NServiceBus.Transport.HostSettings hostSettings, NServiceBus.Transport.ReceiveSettings[] receivers, string[] sendingAddresses, System.Threading.CancellationToken cancellationToken = default) { }
[System.Obsolete("Inject the ITransportAddressResolver type to access the address translation mecha" +
"nism at runtime. See the NServiceBus version 8 upgrade guide for further details" +
". The member currently throws a NotImplementedException. Will be removed in vers" +
"ion 10.0.0.", true)]
public override string ToTransportAddress(NServiceBus.Transport.QueueAddress address) { }
}
public static class RabbitMQTransportSettingsExtensions
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="NServiceBus" Version="9.0.0-alpha.1" />
<PackageReference Include="NServiceBus" Version="9.0.0-alpha.2" />
<PackageReference Include="Particular.Approvals" Version="0.5.0" />
<PackageReference Include="PublicApiGenerator" Version="11.0.0" />
<PackageReference Include="RabbitMQ.Client" Version="6.5.0" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="NServiceBus.TransportTests.Sources" Version="9.0.0-alpha.1" />
<PackageReference Include="NServiceBus.TransportTests.Sources" Version="9.0.0-alpha.2" />
<PackageReference Include="RabbitMQ.Client" Version="6.5.0" />
</ItemGroup>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

<ItemGroup>
<PackageReference Include="BitFaster.Caching" Version="[2.2.0, 3.0.0)" />
<PackageReference Include="NServiceBus" Version="9.0.0-alpha.1" />
<PackageReference Include="NServiceBus" Version="9.0.0-alpha.2" />
<PackageReference Include="RabbitMQ.Client" Version="[6.5.0, 7.0.0)" />
</ItemGroup>

Expand Down
4 changes: 2 additions & 2 deletions src/NServiceBus.Transport.RabbitMQ/RabbitMQTransport.cs
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
/// <summary>
/// Transport definition for RabbitMQ.
/// </summary>
public partial class RabbitMQTransport : TransportDefinition
public class RabbitMQTransport : TransportDefinition
{
TimeSpan heartbeatInterval = TimeSpan.FromSeconds(60);
TimeSpan networkRecoveryInterval = TimeSpan.FromSeconds(10);
Expand Down Expand Up @@ -187,7 +187,7 @@ public override Task<TransportInfrastructure> Initialize(HostSettings hostSettin
/// <inheritdoc />
public override IReadOnlyCollection<TransportTransactionMode> GetSupportedTransactionModes() => new[] { TransportTransactionMode.ReceiveOnly };

// Remove all Legacy API stuff below when PreObsoletes are converted
// Remove all Legacy API stuff below when PreObsoletes are converted

internal string LegacyApiConnectionString { get; set; }

Expand Down
21 changes: 0 additions & 21 deletions src/NServiceBus.Transport.RabbitMQ/obsoletes-v9.cs

This file was deleted.