-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for RabbitMQ.Client v7.0.0 #1446
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielmarbach
force-pushed
the
client-upgrade
branch
from
August 28, 2024 20:12
02123a9
to
61579bc
Compare
paulomorgado
reviewed
Sep 6, 2024
src/NServiceBus.Transport.RabbitMQ.AcceptanceTests/ConfigureEndpointRabbitMQTransport.cs
Outdated
Show resolved
Hide resolved
danielmarbach
changed the title
[Spike] Client Upgrade
Prepare for RabbitMQ.Client v7.0.0
Sep 11, 2024
danielmarbach
force-pushed
the
client-upgrade
branch
from
September 11, 2024 07:02
0ee2877
to
b2e52d9
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
danielmarbach
force-pushed
the
client-upgrade
branch
from
September 11, 2024 10:11
8ccd6dc
to
b2e52d9
Compare
danielmarbach
commented
Sep 14, 2024
src/NServiceBus.Transport.RabbitMQ/Sending/MessageDispatcher.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Paulo Morgado <[email protected]>
This version restores the parameter order from 6.x for `BasicPublishAsync`
bording
force-pushed
the
client-upgrade
branch
from
September 16, 2024 19:27
be8a3a7
to
99bc699
Compare
This reverts commit 99bc699.
…rate wider scope for safety as a trial)
@bording I wasn't able to properly finish the last change because of an appointment. I pushed it nonetheless. Happy to pick this up later if you have no time to continue I missed the sequence number access in the task completion source creation NServiceBus.RabbitMQ/src/NServiceBus.Transport.RabbitMQ/Connection/ConfirmsAwareChannel.cs Line 122 in 59a4e50
|
For example channel operations should not be parallelized.
bording
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.