Move PublishOptionsExtensions to NServiceBus root namespace (#637)

* Move PublishOptionsExtensions to NServiceBus root namespace. * missing approvals Co-authored-by: Tomek Masternak <[email protected]>
Particular · Jun 24, 2020 · b0370a3 · b0370a3
1 parent dfcc228
commit b0370a3
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 11 deletions.
diff --git a/src/NServiceBus.SqlServer.UnitTests/ApprovalFiles/APIApprovals.Approve.approved.txt b/src/NServiceBus.SqlServer.UnitTests/ApprovalFiles/APIApprovals.Approve.approved.txt
@@ -9,6 +9,11 @@ namespace NServiceBus
     {
         public static NServiceBus.SubscriptionMigrationModeSettings EnableMessageDrivenPubSubCompatibilityMode(this NServiceBus.TransportExtensions<NServiceBus.SqlServerTransport> transportExtensions) { }
     }
+    public class static PublishOptionsExtensions
+    {
+        public static void UseCustomSqlConnection(this NServiceBus.PublishOptions options, System.Data.SqlClient.SqlConnection connection) { }
+        public static void UseCustomSqlTransaction(this NServiceBus.PublishOptions options, System.Data.SqlClient.SqlTransaction transaction) { }
+    }
     public class static SendOptionsExtensions
     {
         public static void UseCustomSqlConnection(this NServiceBus.SendOptions options, System.Data.SqlClient.SqlConnection connection) { }
@@ -50,11 +55,6 @@ namespace NServiceBus.Transport.SqlServer
         public void ProcessingInterval(System.TimeSpan interval) { }
         public void TableSuffix(string suffix) { }
     }
-    public class static PublishOptionsExtensions
-    {
-        public static void UseCustomSqlConnection(this NServiceBus.PublishOptions options, System.Data.SqlClient.SqlConnection connection) { }
-        public static void UseCustomSqlTransaction(this NServiceBus.PublishOptions options, System.Data.SqlClient.SqlTransaction transaction) { }
-    }
     public class SubscriptionSettings
     {
         public SubscriptionSettings() { }

diff --git a/...NServiceBus.Transport.SqlServer.UnitTests/ApprovalFiles/APIApprovals.Approve.approved.txt b/...NServiceBus.Transport.SqlServer.UnitTests/ApprovalFiles/APIApprovals.Approve.approved.txt
@@ -9,6 +9,11 @@ namespace NServiceBus
     {
         public static NServiceBus.SubscriptionMigrationModeSettings EnableMessageDrivenPubSubCompatibilityMode(this NServiceBus.TransportExtensions<NServiceBus.SqlServerTransport> transportExtensions) { }
     }
+    public class static PublishOptionsExtensions
+    {
+        public static void UseCustomSqlConnection(this NServiceBus.PublishOptions options, Microsoft.Data.SqlClient.SqlConnection connection) { }
+        public static void UseCustomSqlTransaction(this NServiceBus.PublishOptions options, Microsoft.Data.SqlClient.SqlTransaction transaction) { }
+    }
     public class static SendOptionsExtensions
     {
         public static void UseCustomSqlConnection(this NServiceBus.SendOptions options, Microsoft.Data.SqlClient.SqlConnection connection) { }
@@ -50,11 +55,6 @@ namespace NServiceBus.Transport.SqlServer
         public void ProcessingInterval(System.TimeSpan interval) { }
         public void TableSuffix(string suffix) { }
     }
-    public class static PublishOptionsExtensions
-    {
-        public static void UseCustomSqlConnection(this NServiceBus.PublishOptions options, Microsoft.Data.SqlClient.SqlConnection connection) { }
-        public static void UseCustomSqlTransaction(this NServiceBus.PublishOptions options, Microsoft.Data.SqlClient.SqlTransaction transaction) { }
-    }
     public class SubscriptionSettings
     {
         public SubscriptionSettings() { }

diff --git a/src/NServiceBus.Transport.SqlServer/PublishOptionsExtensions.cs b/src/NServiceBus.Transport.SqlServer/PublishOptionsExtensions.cs
@@ -1,4 +1,4 @@
-namespace NServiceBus.Transport.SqlServer
+namespace NServiceBus
 {
 #if SYSTEMDATASQLCLIENT
     using System.Data.SqlClient;
@@ -8,6 +8,7 @@
     using System;
     using Extensibility;
     using Transport;
+    using Transport.SqlServer;
 
     /// <summary>
     /// Adds transport specific settings to PublishOptions