Add TaskCompletionSource to avoid race (#6865)

* Add TaskCompletionSource to avoid race * Review tweaks --------- Co-authored-by: Brandon Ording <[email protected]>
Particular · Sep 22, 2023 · d3b6827 · d3b6827
1 parent 6d24012
commit d3b6827
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/...iceBus.PersistenceTests/Sagas/When_persisting_a_saga_with_an_escalated_DTC_transaction.cs b/...iceBus.PersistenceTests/Sagas/When_persisting_a_saga_with_an_escalated_DTC_transaction.cs
@@ -17,7 +17,8 @@ public async Task Save_should_fail_when_data_changes_between_concurrent_instance
             var sagaData = new TestSagaData { SomeId = Guid.NewGuid().ToString() };
             await SaveSaga(sagaData);
             var generatedSagaId = sagaData.Id;
-            var enlistmentNotifier = new EnlistmentWhichEnforcesDtcEscalation();
+            var source = new TaskCompletionSource();
+            var enlistmentNotifier = new EnlistmentWhichEnforcesDtcEscalation(source);
 
             Assert.That(async () =>
             {
@@ -51,6 +52,8 @@ public async Task Save_should_fail_when_data_changes_between_concurrent_instance
                 }
             }, Throws.Exception);
 
+            await source.Task.WaitAsync(TimeSpan.FromSeconds(30));
+
             Assert.IsTrue(enlistmentNotifier.RollbackWasCalled);
             Assert.IsFalse(enlistmentNotifier.CommitWasCalled);
         }
@@ -78,7 +81,7 @@ public class StartMessage
             public string SomeId { get; set; }
         }
 
-        class EnlistmentWhichEnforcesDtcEscalation : IEnlistmentNotification
+        class EnlistmentWhichEnforcesDtcEscalation(TaskCompletionSource source) : IEnlistmentNotification
         {
             public bool RollbackWasCalled { get; private set; }
 
@@ -92,17 +95,20 @@ public void Prepare(PreparingEnlistment preparingEnlistment)
             public void Commit(Enlistment enlistment)
             {
                 CommitWasCalled = true;
+                source.SetResult();
                 enlistment.Done();
             }
 
             public void Rollback(Enlistment enlistment)
             {
                 RollbackWasCalled = true;
+                source.SetResult();
                 enlistment.Done();
             }
 
             public void InDoubt(Enlistment enlistment)
             {
+                source.SetResult();
                 enlistment.Done();
             }