Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalized metrics and summary & implemented assignee summary #16

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Generalized metrics and summary & implemented assignee summary #16

wants to merge 15 commits into from

Conversation

sarvo-madhavan
Copy link
Collaborator

  • Generalized summary and metrics
  • Added assignee summary example (data file not included in repo)

OlivierBinette
OlivierBinette requested changes Jun 13, 2022
View reviewed changes
Copy link
Collaborator

@OlivierBinette OlivierBinette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you double-check the example to make sure it's reproducible? I think it's just the data file that needs to be automatically downloaded. Also need to remove paths that are specific to your system.

pv_evaluation/summary/assignee_disambiguation_summary.py Outdated Show resolved Hide resolved
pv_evaluation/summary/utils.py Show resolved Hide resolved
pv_evaluation/summary/utils.py Show resolved Hide resolved
@OlivierBinette
Copy link
Collaborator

I did some cleaning up of the class refactoring. Last thing that needs to be done is to remove system-specific paths from the example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OlivierBinette OlivierBinette OlivierBinette requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sarvo-madhavan @OlivierBinette