Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update create_metadata.py and upload_to_pinata.py #94

Merged
merged 3 commits into from
Apr 12, 2022
Merged

update create_metadata.py and upload_to_pinata.py #94

merged 3 commits into from
Apr 12, 2022

Conversation

snowyaya
Copy link
Contributor

Made changes regarding the issues in #93 and #92

updated breed_to_image_uri and advanced_collectible
put the code under `main()`
@PatrickAlphaC
Copy link
Owner

PatrickAlphaC commented Apr 4, 2022

This is great!

Typically, with python scripts, you'll want to add this at the bottom so python knows to run the script:

if __name__ == "__main__":
    main()

Can you add this to upload_to_pinata.py? (Otherwise it won't run them)

@snowyaya
Copy link
Contributor Author

snowyaya commented Apr 8, 2022

Yes! Updated the pr!

@PatrickAlphaC PatrickAlphaC merged commit aefd084 into PatrickAlphaC:main Apr 12, 2022
@PatrickAlphaC
Copy link
Owner

Thanks so much for this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants