Exception is caught when calling scrape now; this should fix our CI Problems

[thebigG]

Hello everyone,

hope you are all doing well.

Description

When calling scrape function on scrapers, exceptions are caught and an error message is logged. This should fix our CI problems; JobFunnel is not just going to crash if it fails on one of the scrapes because of a CAPTCHA or something like that.

Context of change

Please add options that are relevant and mark any boxes that apply.

• Software (software that runs on the PC)
• Library (library that runs on the PC)
• Tool (tool that assists coding development)
• Other

Type of change

Please mark any boxes that apply.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.
Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration.

• Ran pytest on JobFunnel

Checklist:

Please mark any boxes that have been completed.

• I have performed a self-review of my own code.
• I have commented my code, particularly in hard-to-understand areas.
• I have made corresponding changes to the documentation.
• My changes generate no new warnings.
• I have added tests that prove my fix is effective or that my feature works.
• New and existing unit tests pass locally with my changes.
• Any dependent changes have been merged and published in downstream modules.

[thebigG]

It failed because of #123. Don't merge PR now. Will look at it and fix it.

[PaulMcInnis]

Makes a lot of sense - thanks for improving this behaviour :)

edit: keep us in the loop on 123 i guess, but we may need to create a separate pr for fixing that issue

[thebigG]

edit: keep us in the loop on 123 i guess, but we may need to create a separate pr for fixing that issue

👍. You're right; it will make things simpler. I'll fix #123 and submit another PR, hopefully sometime this week.