-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Germany_German Support #132
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,7 +11,7 @@ | |
from jobfunnel.backend import Job | ||
from jobfunnel.backend.scrapers.base import (BaseCANEngScraper, BaseScraper, | ||
BaseUSAEngScraper, BaseUKEngScraper, | ||
BaseFRFreScraper) | ||
BaseFRFreScraper, BaseGEGerScraper) | ||
from jobfunnel.backend.tools.filters import JobFilter | ||
from jobfunnel.backend.tools.tools import calc_post_date_from_relative_str | ||
from jobfunnel.resources import JobField, Remoteness | ||
|
@@ -406,3 +406,32 @@ def _get_search_url(self, method: Optional[str] = 'get', | |
raise NotImplementedError() | ||
else: | ||
raise ValueError(f'No html method {method} exists') | ||
|
||
class MonsterScraperGEGer(MonsterMetricRadius, BaseMonsterScraper, | ||
BaseGEGerScraper): | ||
"""Scrapes jobs from www.monster.de | ||
""" | ||
def _get_search_url(self, method: Optional[str] = 'get', | ||
page: int = 1) -> str: | ||
"""Get the monster search url from SearchTerms | ||
TODO: implement fulltime/part-time portion + company search? | ||
TODO: implement POST | ||
NOTE: unfortunately we cannot start on any page other than 1, | ||
so the jobs displayed just scrolls forever and we will see | ||
all previous jobs as we go. | ||
""" | ||
if method == 'get': | ||
return ( | ||
'https://www.monster.{}/jobs/search/?{}q={}&where={}' | ||
'&rad={}'.format( | ||
self.config.search_config.domain, | ||
f'page={page}&' if page > 1 else '', | ||
self.query, | ||
self.config.search_config.city.replace(' ', '-'), | ||
self._convert_radius(self.config.search_config.radius) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does German's Monster allow searching by state? If so I think perhaps this is missing here. |
||
) | ||
) | ||
elif method == 'post': | ||
raise NotImplementedError() | ||
else: | ||
raise ValueError(f'No html method {method} exists') |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can remove
_get_search_url
and_get_num_search_result_pages
here as these are defined byBaseIndeedScraper