Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-Provider names are used as a prefix for job ids now. #134

Merged
merged 3 commits into from
Feb 16, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion jobfunnel/__init__.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
"""JobFunnel base package init, we keep module version here.
"""
__version__ = '3.0.1'
__version__ = '3.0.2'
3 changes: 3 additions & 0 deletions jobfunnel/backend/scrapers/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -343,6 +343,9 @@ def scrape_job(self, job_soup: BeautifulSoup, delay: float,
if job and not invalid_job:
try:
job.validate()
# Prefix the id with the scraper name to avoid key conflicts
new_key_id = job.provider + '_' + job.key_id
job.key_id = new_key_id
except Exception as err:
# Bad job scrapes can't take down execution!
# NOTE: desc too short etc, usually indicates that the job
Expand Down
5 changes: 5 additions & 0 deletions readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,11 @@ Open the master CSV file and update the per-job `status`:
```
funnel inline -h
```

# CAPTCHA
JobFunnel does not solve CAPTCHA. If, while scraping, you receive a
`Unable to extract jobs from initial search result page:\` error.
Then open that url on your browser and solve the CAPTCHA manually.

<!-- links -->
[requirements]:requirements.txt
Expand Down