Update to singularity modules production #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Script that produces multiple modules is updated to auto produce several different modules: askap, mpi, nompi, nohost and finally a new one slurm The module template has been updated to include several more libraries required by the newer libfabric. Also adds lustre.
pelahi
added
enhancement
This will result in 4 modules of singularity. This is still yet to be fully tested as that requires installing singularity and then running script as root to set appropriate permissions.
|
Does this PR address my second comment in #177 ? |
This update adds to the system settings references to singularityce and also updates the environment files to install singularityce. It also adds a script that will use the singularityce installation by spack to produce singularity/<version>-* modules.
|
@dipietrantonio I have updated the modules. There is still work to test the GPU and what else might be need to be done. |
|
The script that now processes the modules has comments on the purpose of the sed commands run. |
Added to the template file a GPUMPI regions in the lua file and also extra postprocessing to handle these sections and produce -mpi-gpu and -askap-gpu versions of the singularity modules.
- Added these packages to the repo with some minor corrections. The packages info file has not been updated yet. - Updated the environment to build singularityce rather than older singularity (there are a number of security patches that are present in the newer version).
dipietrantonio
approved these changes
Jul 6, 2023
| {% endif %} | ||
| {% if spec.name == 'python' %}setenv("PYTHONUSERBASE", os.getenv("MYSOFTWARE").."/setonix/python") | ||
| {% if spec.name == 'python' %}setenv("PYTHONUSERBASE", os.getenv("MYSOFTWARE").."/joey/python") |
There was a problem hiding this comment.
This should be left as "setonix". Even though we are building on Joey, we want everything to be like on Setonix. Am I missing something?
| ${dst_dir}/${version/\.lua/-mpi.lua} \ | ||
| >${dst_dir}/${version/\.lua/-nompi.lua} | ||
| -e '/singularity_bindpath *=/ s;/askapbuffer;;g' \ | ||
| -e '/^-- add MPI START/,/^-- add MPI END/{/^-- add MPI START/!{/^-- add MPI END/!d}}' \ |
There was a problem hiding this comment.
I am not very familiar with that syntax, can you break it down for me?
My guess is that you want to delete the lines in the range, so why don't you go with the following?
-e '/^-- add MPI START/,/^-- add MPI END/d'
ddeeptimahanti
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Script that produces multiple modules is updated to auto produce several different modules: askap, mpi, nompi, nohost and finally a new one slurm
The module template has been updated to include several more libraries required by the newer libfabric. Also adds lustre.