Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A spack wrapper to provide single command to handle user and project installations #202

Merged
merged 2 commits into from
Aug 23, 2023

Conversation

dipietrantonio
Copy link
Collaborator

Instead of having two executables, spack and spack_project.sh, we should have a single spack command with a project subcommand to handle project installations. The proposed solution provides a cleaner interface to users.

@dipietrantonio
Copy link
Collaborator Author

This PR partially addresses #174

@marcodelapierre
Copy link
Contributor

I am not sure about the proposal:

I am assuming that most Spack usage is a user-only one, rather than project one; for this reason, I think it can be beneficial to retain the standard, more concise spack syntax for such common usage, and resort to a different, more wordy syntax for the project case. This was indeed the rationale behind my original design.

This being said, I think it is super beneficial to discuss this aspect.

@dipietrantonio @pelahi @ddeeptimahanti

@dipietrantonio
Copy link
Collaborator Author

I think it can be beneficial to retain the standard, more concise spack syntax for such common usage,

And that is what happens. Users can execute spack as usual for their user installations.

spack spec -I cfitsio
spack install -j 128 cfitsio

the above is supported by the script. It offers the same interface.

When users want to install something systemwide, then they use the project spack command that this script introduces. There is no project command in Spack so there is no overlap.

Users can do

spack project spec -I cfitsio
spack project install cfitsio

The script replaces the project subcommand with -C <path to config files>

@marcodelapierre
Copy link
Contributor

Thanks for clarifying - I love this solution!

Copy link
Contributor

@marcodelapierre marcodelapierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@ddeeptimahanti ddeeptimahanti self-requested a review August 22, 2023 10:47
@ddeeptimahanti
Copy link
Collaborator

Nice solution @dipietrantonio - need to update the relevant documentation

@dipietrantonio
Copy link
Collaborator Author

Thanks @ddeeptimahanti ! Yes I will.

@dipietrantonio dipietrantonio merged commit b432ba8 into main Aug 23, 2023
@dipietrantonio dipietrantonio deleted the cdp-spack-wrapper branch August 23, 2023 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants