Fix initial snapshot replay #2168
Open
+204
−184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serprex
force-pushed
the
fix-initial-snapshot-replay
branch
from
b57b2e6
to
2696b10
Compare
iskakaushik
reviewed
Oct 22, 2024
iskakaushik
reviewed
Oct 22, 2024
serprex
force-pushed
the
fix-initial-snapshot-replay
branch
from
813a205
to
986928a
Compare
serprex
force-pushed
the
fix-initial-snapshot-replay
branch
from
2e030a7
to
1707891
Compare
serprex
force-pushed
the
fix-initial-snapshot-replay
branch
from
1707891
to
55b781c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During replay connection is reset, invalidating snapshot name. In replays we want to drop slot from failed run & use newly exported snapshot name. That means slot/snapshot name cannot end up in temporal history
Another challenge is child qrep activities are running on peerflow workers, whereas connection is maintained by session on snapshot worker. So instead of relying on maps in session memory, use catalog to share names between workers