Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send standby status once a minute #2217

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

serprex
Copy link
Contributor

@serprex serprex commented Nov 4, 2024

also enable wal heartbeats by default. users predating PG14 should change the query or disable wal heartbeats

Heartbeats were being sent but for some reason RDS never sets off PKM

Copy link
Member

@iamKunalGupta iamKunalGupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's test and merge

@iamKunalGupta iamKunalGupta linked an issue Nov 4, 2024 that may be closed by this pull request
also enable wal heartbeats by default. users predating PG14 should change the query or disable wal heartbeats

Heartbeats were being sent but for some reason RDS never sets off PKM
@serprex
Copy link
Contributor Author

serprex commented Nov 4, 2024

Sending updated LSN & logging that updated LSN. PG is ignoring when we send unrequested standby status updates with updated LSN

@serprex serprex marked this pull request as draft November 5, 2024 13:36
@iamKunalGupta
Copy link
Member

@serprex do we need to send WalFlushPosition instead for RDS?

@iamKunalGupta
Copy link
Member

@serprex do we need to send WalFlushPosition instead for RDS?

nvm, the library does it for us

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable heartbeats by default
3 participants